Fix GLES2 ambient light flickering with multiple refprobes #53740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clayjohn
approved these changes
Oct 12, 2021
There was a problem hiding this comment.
Looks good, subject to CI passing!
edit: for future reference, this PR fixes the ambient light flickering experienced by users when there are 2 or more probes in the scene and it documents the limitation that each object on receives light from the nearest 2 reflection probes
akien-mga
reviewed
Oct 12, 2021
clktmr
force-pushed
the
gles2-multiple-refprobes
branch
from
6cffd12
to
3e5ee9c
Compare
|
Can you please squash your two commits into one before we merge? How to do so is described here: https://docs.godotengine.org/en/latest/community/contributing/pr_workflow.html#the-interactive-rebase |
This patch fixes rendering of multiple reflection probes for a single mesh in the GLES2 renderer. If there were two reflection probes, one of them would always have the `interior` option flipped, resulting in broken blending between probes and flickering of ambient reflection. Also make note of GLES2 reflection probe limit
clktmr
force-pushed
the
gles2-multiple-refprobes
branch
from
3e5ee9c
to
e230bc6
Compare
JFonS
approved these changes
Oct 13, 2021
|
Windows build failure is unrelated to this PR (GitHub Actions availability issue). |
|
Thanks! |
akien-mga
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36399