WebM: Disable SIMD optimization with YASM on Windows #53959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It triggers a crash when playing V9 videos. Could likely be fixed if anyone wants to work on it, but so far nobody seems to want to and WebM support is dropped in 4.0, so this workaround should help for now. Fixes godotengine#50862.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It triggers a crash when playing V9 videos.
Could likely be fixed if anyone wants to work on it, but so far nobody seems to
want to and WebM support is dropped in 4.0, so this workaround should help for
now.
Fixes #50862.
This shouldn't impact 3.4 beta/RC builds as those were already built without YASM. But once cherry-picked for
3.3it should fix #50862 for a potential 3.3.5, and for custom builds of users who installed yasm. CC @zaeviDocumentation updated accordingly in godotengine/godot-docs#5332.