Fix action exact match (Also fixes ui_ focus keys) #54173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanfranke
force-pushed
the
fix-exact-match
branch
from
9984b9b
to
e8e53d7
Compare
nathanfranke
force-pushed
the
fix-exact-match
branch
from
e8e53d7
to
f0ba99d
Compare
akien-mga
reviewed
Nov 29, 2021
nathanfranke
force-pushed
the
fix-exact-match
branch
from
f0ba99d
to
e0bd576
Compare
nathanfranke
force-pushed
the
fix-exact-match
branch
2 times, most recently
from
1939a23
to
d880c6e
Compare
nathanfranke
changed the title
nathanfranke
force-pushed
the
fix-exact-match
branch
2 times, most recently
from
cffdf79
to
ab489b3
Compare
nathanfranke
force-pushed
the
fix-exact-match
branch
from
ab489b3
to
52fed27
Compare
akien-mga
reviewed
Jan 12, 2022
nathanfranke
force-pushed
the
fix-exact-match
branch
from
52fed27
to
ef3d178
Compare
akien-mga
reviewed
Jan 24, 2022
nathanfranke
force-pushed
the
fix-exact-match
branch
from
ef3d178
to
0f1dcde
Compare
|
Thanks for reviewing, sorry for missing those extra consts so many times now! Should be ready now. |
nathanfranke
force-pushed
the
fix-exact-match
branch
from
0f1dcde
to
dc1c4cf
Compare
bruvzg
approved these changes
Jan 24, 2022
akien-mga
reviewed
Jan 26, 2022
Comment on lines
+896
to
+900
| // Matches even if not in the same direction, but returns a "not pressed" event. | ||
| bool match = axis == jm->axis; | ||
| if (p_exact_match) { | ||
| match &= (axis_value < 0) == (jm->axis_value < 0); | ||
| } |
There was a problem hiding this comment.
I'm a bit concerned about the potential impact of this change on joypad motion events.
I guess let's merge and assess while testing whether this is working as expected.
akien-mga
approved these changes
Jan 26, 2022
|
Thanks! |
This was referenced Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #54602
Fixes #55622
Supersedes #54842
3.x version: #54174
Previously,
event.is_action_pressed("test", false, true)always returned false, whileevent.is_action_released("test", false, true)returned true both for pressed and released. This is because the pressed pointer was not passed intois_match. This PR fixes it by usingaction_matchinstead.MRP: Test10.zip