Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename PROPERTY_USAGE_NOEDITOR to PROPERTY_USAGE_NO_EDITOR #54571

Merged

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Nov 3, 2021

This is consistent with other constants that include NO, such as PROPERTY_HINT_COLOR_NO_ALPHA.

See #54161 (comment).

This is consistent with other constants that include `NO`,
such as `PROPERTY_HINT_COLOR_NO_ALPHA`.
@Calinou Calinou requested review from a team as code owners November 3, 2021 22:07
@Calinou Calinou added this to the 4.0 milestone Nov 3, 2021
@Calinou Calinou removed request for a team November 3, 2021 22:07
@Calinou Calinou removed request for a team November 3, 2021 22:07
@fire
Copy link
Member

fire commented Nov 3, 2021

The reasoning of consistency for naming follows logically. 👍

@akien-mga akien-mga merged commit 78931aa into godotengine:master Nov 3, 2021
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants