-
-
Notifications
You must be signed in to change notification settings - Fork 20.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a theme constant to change LineEdit and TextEdit's caret width #54956
Add a theme constant to change LineEdit and TextEdit's caret width #54956
Conversation
Shouldn't we always multiply it by scale? And thus the default would be 1. |
This doesn't seem to close godotengine/godot-proposals#1220? Not sure about exposing the width, but rather we should port the |
This PR provides a close enough solution for the 90% use case. Using arbitrary textures for the caret is a very uncommon use case, and I don't feel it's worth supporting in core. As long as there's a way to get the caret position in pixels, it's possible to hide the default caret by setting its color to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we always multiply it by scale? And thus the default would be 1.
I agree, it's probably better to always use theme scaling, otherwise looks good.
ea51fe1
to
18f64d6
Compare
18f64d6
to
ed175e1
Compare
Rebased and tested again, it works as expected. |
Will you address this concern? 🙃 |
ed175e1
to
32c6bc2
Compare
Done (and tested again) 🙂 I thought I had addressed it before, but I didn't. |
91bac8a
to
696102c
Compare
This can be useful to improve caret visibility, especially at larger font sizes. This can also be used for accessibility purposes.
696102c
to
f6443be
Compare
Thanks! |
This can be useful to improve caret visibility, especially at larger font sizes. This can also be used for accessibility purposes.
This closes godotengine/godot-proposals#1220.
Preview