Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows, 3.x] Detect new Windows Terminal and disable unsupported set_console_visible code. #55967

Merged
merged 1 commit into from
Dec 16, 2021

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Dec 15, 2021

Same as #55966 for 3.x

Tested on Windows 11 21H1(22000.348) with:

  • Windows Console Host (Old terminal)
  • ConEmu 210912
  • Windows Terminal 1.11.2921.0

@bruvzg bruvzg added this to the 3.5 milestone Dec 15, 2021
@bruvzg bruvzg requested a review from a team as a code owner December 15, 2021 18:06
@bruvzg bruvzg changed the title [Windows] Detect new Windows Terminal and disable unsupported set_console_visible code. [Windows, 3.x] Detect new Windows Terminal and disable unsupported set_console_visible code. Dec 15, 2021
@akien-mga akien-mga merged commit 62b181a into godotengine:3.x Dec 16, 2021
@akien-mga
Copy link
Member

Cherry-picked for 3.4.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants