Fix Blend Shapes when Octahedral Compression is Used #56161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blend shapes did not take into account octahedral compressed vertex attribute layouts and this resulted in incorrect lighting on the resulting blended mesh Now make the blend_shapes shader octahedral compression aware!
|
This should fix #55633 |
|
Can you show a before and after visual comparisons? The code is hard to check cases for so my test plan is to run blend shape examples from the bug reports. |
|
Sure thing - here's a before and after using the example from the bug report with the blend set to 0.6 Before: After: |
clayjohn
approved these changes
Dec 28, 2021
akien-mga
approved these changes
Jan 4, 2022
|
Thanks! |
|
Cherry-picked for 3.4.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blend shapes did not take into account octahedral compressed vertex
attribute layouts and this resulted in incorrect lighting on the
resulting blended mesh
Now make the blend_shapes shader octahedral compression aware!
Bugsquad edit: Fixes #55633.