Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.x] Fix getting properties state when reloading C# #56300

Merged
merged 1 commit into from
Dec 29, 2021
Merged

[3.x] Fix getting properties state when reloading C# #56300

merged 1 commit into from
Dec 29, 2021

Conversation

raulsntos
Copy link
Member

@raulsntos raulsntos commented Dec 28, 2021 •
edited
Loading

3.x version of #56299

@raulsntos raulsntos added bug topic:editor topic:dotnet cherrypick:3.x Considered for cherry-picking into a future 3.x release cherrypick:3.4 labels Dec 28, 2021
@raulsntos raulsntos requested a review from a team as a code owner December 28, 2021 18:12
@raulsntos
Fix getting properties state when reloading C#
907e709 
When reloading C# classes and keep their properties values they are
retrieved and stored in a state list.
Retrieving the properties was only getting the fields of the C# class
and not inherited fields so those properties values were lost on reload.
Now we also try to find the field in the parent classes.
@raulsntos raulsntos added this to the 3.5 milestone Dec 28, 2021
@raulsntos raulsntos mentioned this pull request Dec 28, 2021
Closed
@akien-mga akien-mga merged commit 4e4dead into godotengine:3.x Dec 29, 2021
@akien-mga
Copy link
Member

Thanks!

@raulsntos raulsntos deleted the fix-37812-3.x branch December 29, 2021 12:26
@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Jan 5, 2022
@akien-mga
Copy link
Member

Cherry-picked for 3.4.3.

DwarfNinja added a commit to DwarfNinja/DwarfGame-Project that referenced this pull request Jan 6, 2022
@DwarfNinja
Replaced ResourceWrappers for C# Resources
9382639 
Built custom Mono Godot Editor which fixes Issue godotengine/godot#37812 that previously required use of the ResourceWrapper class to fix.

Version: 3.4.2-stable

Added Commit: godotengine/godot@907e709

Related Pull Request: godotengine/godot#56300
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neikeq neikeq neikeq approved these changes

Assignees
No one assigned
Labels
bug topic:dotnet topic:editor
Projects
None yet
Milestone
3.5
Development

Successfully merging this pull request may close these issues.
3 participants
@raulsntos @akien-mga @neikeq