[3.x] Add type variations to Theme
#57942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
approved these changes
Feb 17, 2022
YuriSizov
force-pushed
the
theme-type-variations-3.x
branch
from
eacc5f5
to
df13466
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #47544 and #50169.
This PR makes it possible to define sub-types, or type variations, for theme types. Basically, in your project theme you can define a type
BlueButtonand make it variation ofButton. Now, every button in your project can pick to use that variation as its base theme type. This way, you can define everything about these buttons using a singleThemeresource instead of manually and painstakingly overriding each theme property every time.2022-02-11_00-20-29.mp4
Fully editable with the theme editor and also can be picked with the control picker:
godot.windows.tools.64_2022-02-11_00-25-21.mp4