Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an OS.get_processor_name() method (3.x) #58157

Merged
merged 1 commit into from
Feb 17, 2022

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Feb 15, 2022

3.x version of #44716.

This method can be used to get the CPU model name. It can be used in conjunction with VisualServer.get_video_adapter_name() and VisualServer.get_video_adapter_vendor() for annotating benchmarks and automatic graphics quality configuration.

Preview

image

@Calinou Calinou requested review from a team as code owners February 15, 2022 21:26
@Calinou Calinou changed the title Add an OS.get_processor_name() method Add an OS.get_processor_name() method (3.x) Feb 15, 2022
@Calinou Calinou added this to the 3.5 milestone Feb 15, 2022
platform/windows/os_windows.cpp Outdated Show resolved Hide resolved
platform/windows/os_windows.cpp Outdated Show resolved Hide resolved
@Calinou Calinou force-pushed the os-add-get-processor-name-3.x branch from 1e676e6 to b4a0f0d Compare February 16, 2022 17:38
This method can be used to get the CPU model name.
It can be used in conjunction with
`VisualServer.get_video_adapter_name()` and
`VisualServer.get_video_adapter_vendor()` for annotating benchmarks
and automatic graphics quality configuration.
@Calinou Calinou force-pushed the os-add-get-processor-name-3.x branch from b4a0f0d to 7f9e974 Compare February 16, 2022 17:39
@akien-mga akien-mga merged commit 47e34dc into godotengine:3.x Feb 17, 2022
@akien-mga
Copy link
Member

Thanks!

@Calinou Calinou deleted the os-add-get-processor-name-3.x branch February 17, 2022 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants