Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] GDScript: Don't coerce default values to the export hint type #58686

Merged
merged 1 commit into from
Mar 10, 2022

Conversation

vnen
Copy link
Member

@vnen vnen commented Mar 2, 2022

This behavior is inconsistent with non tools builds and can create issues. Instead, a warning is emitted if there's a type mismatch. If the type can't be converted, an error is shown instead.

For the editor it gives a converted value to avoid issues with the property editor, which expects the correct type.

Fix #39215

@vnen vnen added this to the 3.5 milestone Mar 2, 2022
@vnen vnen requested a review from a team as a code owner March 2, 2022 14:00
@vnen vnen force-pushed the gdscript-warn-export-type-mismatch branch from 00f7a4b to 5734a3f Compare March 2, 2022 14:31
This behavior is inconsistent with non tools builds and can create
issues. Instead, a warning is emitted if there's a type mismatch. If the
type can't be converted, an error is shown instead.

For the editor it gives a converted value to avoid issues with the
property editor, which expects the correct type.
@vnen vnen force-pushed the gdscript-warn-export-type-mismatch branch from 5734a3f to f2166ba Compare March 2, 2022 15:26
@vnen vnen requested a review from a team as a code owner March 2, 2022 15:26
@akien-mga akien-mga merged commit 1cf444a into godotengine:3.x Mar 10, 2022
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants