LSP: Fix wrong parentheses for function call autocompletion #59482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* GDScriptLanguage::complete_code already adds parentheses to function calls, and does this a lot smarter than the language server right now. * Instead of the previous naive approach we now reuse the same logic as the internal editor. * For this to have any effect we also have to send the `insertText` field already during the completionRequest and not only during resolve.
kurtlachmann
force-pushed
the
lsp_better_parentheses
branch
from
d436805
to
bbb07ff
Compare
vnen
approved these changes
Jun 15, 2022
|
Thanks! |
|
Is this eligible for a |
akien-mga
added
the
cherrypick:3.x
|
Cherry-picked for 3.5. |
akien-mga
removed
the
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GDScriptLanguage::complete_code()already defines its owninsert_textfield. Instead of coming up with our own (naive) logic we should reuse that. It also adds the parentheses to function calls but its algorithm is smarter and already considers edge cases like e.g. type hints.For this to have any effect we also have to send the
insertTextfield already during the completionRequest and not only during resolve. But this is actually the recommended behavior according to the LSP specification so it's a step in the right direction anyway.