Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tonemapper shader to correctly apply alpha channel #61109

Merged
merged 1 commit into from
May 18, 2022

Conversation

Chaosus
Copy link
Member

@Chaosus Chaosus commented May 17, 2022

Changed a tone map shader to use an alpha channel from the input texture.

This should fix a bug with transparent_bg in viewports:
image

Fix #40651

Bugsquad edit: master version of #54585.

@Chaosus Chaosus requested a review from a team as a code owner May 17, 2022 08:03
@Chaosus Chaosus added this to the 4.0 milestone May 17, 2022
@Chaosus Chaosus force-pushed the fix_tonemap branch 5 times, most recently from 90ddf6c to bcae94a Compare May 17, 2022 08:20
Copy link
Contributor

@BastiaanOlij BastiaanOlij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me and makes sense. I think there are other effects that may require a similar fix. I do know that DOF (I think) uses the alpha channel for weights and shouldn't overwrite the alpha of the end result.

@Chaosus
Copy link
Member Author

Chaosus commented May 18, 2022

@BastiaanOlij Yeah, I didn't touch other effects since I usually don't like to touch the things I've little to know ^^ to prevent accidental breakage.

@akien-mga akien-mga merged commit 4e6f5bf into godotengine:master May 18, 2022
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vulkan: transparent_bg property in SubViewport has no effect (not reimplemented yet)
3 participants