Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update android:targetSdkVersion from 30 to 31 #62297

Conversation

gumaciel
Copy link
Contributor

@gumaciel gumaciel commented Jun 22, 2022

Starting in August 2022, new apps will need to target API level 31 (Android 12) or higher and adjust for behavioral changes.

Read more here: https://developer.android.com/google/play/requirements/target-sdk

This change should be easily cherry-picked for 3.x and maybe release on 3.5 before release the stable version.

Btw this is my first PR on Godot 😁, if i need to do other thing that i don't know to this be merged please let me know.

@gumaciel gumaciel requested a review from a team as a code owner June 22, 2022 02:50
@m4gr3d
Copy link
Contributor

m4gr3d commented Jun 22, 2022

@gumaciel Thanks for the contribution, but the update is already covered in #51815.

@akien-mga
Copy link
Member

akien-mga commented Jun 22, 2022

@m4gr3d if this change is sufficient to satisfy platform requirements, I think we should still merge it at least for 3.4.5 as we won't include the full scoped storage there.

For 3.5 it depends on whether we decide to merge #51815 so close to the 3.5-stable release.

Reopening for now for discussion.

@akien-mga akien-mga reopened this Jun 22, 2022
@akien-mga akien-mga added cherrypick:3.x Considered for cherry-picking into a future 3.x release cherrypick:3.4 and removed archived labels Jun 22, 2022
@akien-mga akien-mga added this to the 4.0 milestone Jun 22, 2022
@m4gr3d
Copy link
Contributor

m4gr3d commented Jun 23, 2022

@m4gr3d if this change is sufficient to satisfy platform requirements, I think we should still merge it at least for 3.4.5 as we won't include the full scoped storage there.

For 3.5 it depends on whether we decide to merge #51815 so close to the 3.5-stable release.

Reopening for now for discussion.

@akien-mga If we're planning to have more 3.4.x releases then the scoped storage PR should also be included in the 3.4.x branch otherwise we'll introduce too significant of a delta making future storage related fixes harder to merge.

The scoped storage update itself doesn't break compat so it can be backported to the 3.4.x branch.
If we consider it too risky then the scope storage update can go in the 3.5 branch, and can be backported later to the 3.4.6 release.

@akien-mga
Copy link
Member

akien-mga commented Jun 23, 2022

@m4gr3d I don't think it's worth it, 3.4.5 will likely be the last 3.4 release and we normally don't add new features/change behaviour in a stable branch, especially not in the last point release. We just need 3.4.x to stay usable for existing published games. People who need scoped storage should just move to 3.5.

@m4gr3d
Copy link
Contributor

m4gr3d commented Jun 23, 2022

@m4gr3d I don't think it's worth it, 3.4.5 will likely be the last 3.4 release and we normally don't add new features/change behaviour in a stable branch, especially not in the last point release. We just need 3.4.x to stay usable for existing published games. People who need scoped storage should just move to 3.5.

Then yes, we should merge this change for 3.4.5 then!

You can cherry-pick this change in the 3.5 branch as well. If we merge #51815, it'll just override/complement the changes made here.

@akien-mga
Copy link
Member

Looks good! Could you squash the commits? See PR workflow for instructions.

Starting in August 2022, new apps will need to target API level 31 (Android 12) or higher and adjust for behavioral changes.

Read more here: https://developer.android.com/google/play/requirements/target-sdk
@akien-mga akien-mga force-pushed the update_android_targetSdkVersion_30_to_31 branch from 155d3f4 to ec6d5d6 Compare June 23, 2022 13:17
@akien-mga akien-mga merged commit b39b871 into godotengine:master Jun 23, 2022
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

@akien-mga
Copy link
Member

Cherry-picked for 3.5.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Jun 23, 2022
@akien-mga
Copy link
Member

Cherry-picked for 3.4.5.

@gumaciel
Copy link
Contributor Author

Thank you guys! I hope to contribute more!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants