[3.x] X11: Properly check for fullscreen toggle made through the Window Manager #62543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Did you try |
akien-mga
approved these changes
Jun 30, 2022
There was a problem hiding this comment.
Tested the fix, it seems to work well on KDE / KWin for the described bug, i.e. fullscreen being forced on/off by the window manager.
No regression observed for the workflow where fullscreen is set by Godot itself (either using OS.window_fullscreen, project setting or passing --fullscreen on the command line).
Code seems fine too, similar to window_maximize_check and properly frees the Atom.
|
Thanks! |
This was referenced Jun 30, 2022
|
Cherry-picked for 3.4.5. |
akien-mga
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40007.
I'm unable to check if
masteris affected since the Editor does not open for me on that branch.