Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Default cursor fix in html5 export. #62608

Merged
merged 1 commit into from
Jul 2, 2022

Conversation

RPicster
Copy link
Contributor

@RPicster RPicster commented Jul 1, 2022

3.x backport of #62607

@RPicster RPicster requested a review from a team as a code owner July 1, 2022 18:54
@RPicster RPicster changed the title Fix default cursor in html5 export. Default cursor fix in html5 export. Jul 1, 2022
@RPicster RPicster changed the title Default cursor fix in html5 export. [3.x] Default cursor fix in html5 export. Jul 1, 2022
@akien-mga akien-mga added this to the 3.5 milestone Jul 1, 2022
@Faless Faless merged commit e1447ec into godotengine:3.x Jul 2, 2022
@Faless
Copy link
Collaborator

Faless commented Jul 2, 2022

Thanks!

RPicster added a commit to someengineering/resoto-ui that referenced this pull request Jul 5, 2022
- Changed terminal font
- Changing driver to GLES2
- Added a persistent terminal command history (saved in browsers local storage)
- Improved UX of the terminal to match the behaviour of a "normal" terminal more
- Fixed copy and pasting on Chrome + Safari (Firefox ❌ https://developer.mozilla.org/en-US/docs/Web/API/Clipboard/readText#browser_compatibility)
- Fixed shortcuts on MacOS
- Improved timeout handling
- Fixed a problem where extensions would steal input from Resoto UI*

The last point is certainly not the perfect solution. Different extensions steal input at window level, the only solution is to "play along" - the Godot canvas element is now using `contenteditable=true`.
To make this work and display the correct cursors, new export templates for Godot were compiled and put into our export template repo as a new release.
godotengine/godot#62608 This fix is adjusting the cursor from `auto` to `default` in the engine.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants