[Command line export] return 0 exit code when export is finished with warnings. #62907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruvzg
added
enhancement
topic:editor
usability
cherrypick:3.x
akien-mga
reviewed
Jul 15, 2022
| @@ -923,6 +923,7 @@ void EditorNode::_fs_changed() { | |||
|
|
|||
| // FIXME: Move this to a cleaner location, it's hacky to do this in _fs_changed. | |||
| String export_error; | |||
| Error err = OK; | |||
There was a problem hiding this comment.
Might be less error prone to add String export_warning; and rely on this to print errors and/or warnings and set the exit code accordingly?
akien-mga
approved these changes
Jul 25, 2022
|
Thanks! |
|
Cherry-picked for 3.5. |
akien-mga
removed
the
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes command line export exit code to
EXIT_SUCCESSandERR_PRINTtoWARN_PRINTif non-critical errors were encountered during the export process (e.g., rcedit was unable to change executable icon.)Bugsquad edit: Fixes #62874.