Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDNative: Expose String::num_uint64, and use bool in capitalized versions #63136

Merged
merged 1 commit into from
Jul 18, 2022

Conversation

akien-mga
Copy link
Member

@akien-mga akien-mga commented Jul 18, 2022

Exposed in Core API 1.3 added in 3.5.

Supersedes #50806.

…versions

Exposed in Core API 1.3 added in 3.5.
memnew_placement(&result, String(String::num_int64(p_num, p_base, true)));
memnew_placement(&result, String(String::num_int64(p_num, p_base, p_capitalize_hex)));
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It made no sense to have a p_capitalize_hex argument but always use true.
This could have been fixed by simply removing the bool, but that would break the API so instead I used it.

@akien-mga akien-mga merged commit 7e9f55c into godotengine:3.x Jul 18, 2022
@akien-mga akien-mga deleted the 3.x-gdnative-string-num-uint64 branch July 18, 2022 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant