prevent SystemTime panics #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
let's wait till your upstream PR is merged, otherwise, this might get messy. once merged, you can do something like #57, resolve conflicts, and add your SystemTime panic fix. |
|
Yeah, I just wanted to you guys to see it and shout if something looks terrible 😄 |
niklasad1
changed the title
niklasad1
changed the title
|
upstream PR is merged, can you update this now? @niklasad1 |
|
Cool, yes I will take of it today |
niklasad1
force-pushed
the
checked-systemtime
branch
from
5926a7d
to
8fb1b38
Compare
niklasad1
force-pushed
the
checked-systemtime
branch
from
8fb1b38
to
ea5d77f
Compare
soc1c
approved these changes
Mar 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
blocked on #69