Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Users search API should be sorted by most match order #17859

Closed
AllForNothing opened this issue Nov 25, 2022 · 1 comment · Fixed by #18273
Closed

Users search API should be sorted by most match order #17859

AllForNothing opened this issue Nov 25, 2022 · 1 comment · Fixed by #18273
Assignees
@stonezdj
Labels
area/API needs/triage triage issue before assigning target/2.8.0

Comments

@AllForNothing
Copy link
Contributor

AllForNothing commented Nov 25, 2022 •
edited
Loading

Now LDAP group search API supports sorting by match order,

But users search API still does not support sorting by match order. Maybe, we should let them have the consistent behavior
image
@AllForNothing AllForNothing changed the title All search APIs should be sorted by most match order Users search API should be sorted by most match order Nov 25, 2022
@AllForNothing AllForNothing self-assigned this Nov 25, 2022
@AllForNothing AllForNothing added the needs/triage triage issue before assigning label Nov 25, 2022
stonezdj pushed a commit to stonezdj/harbor that referenced this issue Dec 15, 2022
Sort user and usergroup by most match order
a0a2135 
  fixes goharbor#17859

Signed-off-by: stonezdj <daojunz@vmware.com>
@AllForNothing AllForNothing mentioned this issue Dec 15, 2022
Closed
@github-actions
Copy link

github-actions bot commented Feb 6, 2023

This issue is being marked stale due to a period of inactivity. If this issue is still relevant, please comment or remove the stale label. Otherwise, this issue will close in 30 days.

@github-actions github-actions bot added the Stale label Feb 6, 2023
stonezdj pushed a commit to stonezdj/harbor that referenced this issue Feb 23, 2023
Sort user and usergroup by most match order
3e367c0 
  fixes goharbor#17859

Signed-off-by: stonezdj <daojunz@vmware.com>
@stonezdj stonezdj mentioned this issue Feb 23, 2023
Merged
5 tasks
stonezdj pushed a commit to stonezdj/harbor that referenced this issue Mar 1, 2023
@stonezdj
Sort user and usergroup by most match order
e96900c 
  fixes goharbor#17859

Signed-off-by: stonezdj <daojunz@vmware.com>
stonezdj added a commit that referenced this issue Mar 1, 2023
@stonezdj
Sort user and usergroup by most match order (#18273)
320c64e 
fixes #17859

Signed-off-by: stonezdj <daojunz@vmware.com>
sebglon pushed a commit to sebglon/harbor that referenced this issue Mar 6, 2023
@stonezdj @sebglon
Sort user and usergroup by most match order (goharbor#18273)
ca2751b 
fixes goharbor#17859

Signed-off-by: stonezdj <daojunz@vmware.com>
yankay pushed a commit to yankay/harbor that referenced this issue Mar 8, 2023
@stonezdj @yankay
Sort user and usergroup by most match order (goharbor#18273)
9b8e9c1 
fixes goharbor#17859

Signed-off-by: stonezdj <daojunz@vmware.com>
yankay added a commit to yankay/harbor that referenced this issue Mar 8, 2023
@yankay
enable-gzip
ca49e0d 
Signed-off-by: Kay Yan <kay.yan@daocloud.io>

Improve swagger descriptions (without changing security settings) (goharbor#18205)

* Improve swagger definitions.

References goharbor#15624

Remove chartmuseum test case (goharbor#18267)

Harbor deprecates chartmuseum as of v2.8.0
Epic: goharbor#17958
Discussion: goharbor#15057

Signed-off-by: Yang Jiao <jiaoya@vmware.com>

Remove chart api (goharbor#18265)

* remove chart api from swagger

Delete the api path for chart in the swagger

Signed-off-by: Wang Yan <wangyan@vmware.com>

* Remove chart APIs
   1. Remove some chart-related steps for Dockerfile for portal  container
   2. Remove chart APIs for API center

Signed-off-by: AllForNothing <sshijun@vmware.com>

---------

Signed-off-by: Wang Yan <wangyan@vmware.com>
Signed-off-by: AllForNothing <sshijun@vmware.com>
Co-authored-by: Wang Yan <wangyan@vmware.com>

Sort user and usergroup by most match order (goharbor#18273)

fixes goharbor#17859

Signed-off-by: stonezdj <daojunz@vmware.com>

Update the replication rule related to the Chartmuseum (goharbor#18274)

Update the registry and replication rule related to the Chartmuseum

Update replication_policy and registry as Harbor v2.8.0 deprecates chartmuseum.
Harbor deprecates chartmuseum as of v2.8.0
Epic: goharbor#17958
Discussion: goharbor#15057

Signed-off-by: Yang Jiao <jiaoya@vmware.com>

refactor: refact the webhook API and life process (goharbor#18255)

refactor: refact the notification job API and life process

1. Introduce new APIs for webhook jobs management.
2. Refact legacy APIs for backforward compatible.
3. Migrate the webhook jobs process to unified execution/task framework.

Closes: goharbor#18210

Signed-off-by: chlins <chenyuzh@vmware.com>

Add retry times for calling CVE data export execution list API (goharbor#18297)

1.Fixes goharbor#17879
2.Add retry times to avoid endless API calls for CVE data export execution list API

Signed-off-by: AllForNothing <sshijun@vmware.com>

Get job log by job_id in worker (goharbor#18261)

Get job by job_id in redis

  Get the last 10MB of data if it exceeds 10MB

Signed-off-by: stonezdj <daojunz@vmware.com>

Enhance webhook UI (goharbor#18291)

1. Add execution list for a certain webhook policy
  2. Add task list for a certain execution

Signed-off-by: AllForNothing <sshijun@vmware.com>

Update UI for the deprecation of Artifact Hub (goharbor#18303)

1. Update edit-registry page to enable the edition for Artifact Hub
2. Update edit-replication-rule page to enable the edition for rules contain Artifact Hub

Signed-off-by: AllForNothing <sshijun@vmware.com>

Add logs column for worker datagrid (goharbor#18307)

1. Related back-end PR goharbor#18261

Signed-off-by: AllForNothing <sshijun@vmware.com>
yankay added a commit to yankay/harbor that referenced this issue Mar 8, 2023
@yankay
enable-gzip
9791c35 
Signed-off-by: Kay Yan <kay.yan@daocloud.io>

Improve swagger descriptions (without changing security settings) (goharbor#18205)

* Improve swagger definitions.

References goharbor#15624

Remove chartmuseum test case (goharbor#18267)

Harbor deprecates chartmuseum as of v2.8.0
Epic: goharbor#17958
Discussion: goharbor#15057

Signed-off-by: Yang Jiao <jiaoya@vmware.com>

Remove chart api (goharbor#18265)

* remove chart api from swagger

Delete the api path for chart in the swagger

Signed-off-by: Wang Yan <wangyan@vmware.com>

* Remove chart APIs
   1. Remove some chart-related steps for Dockerfile for portal  container
   2. Remove chart APIs for API center

Signed-off-by: AllForNothing <sshijun@vmware.com>

---------

Signed-off-by: Wang Yan <wangyan@vmware.com>
Signed-off-by: AllForNothing <sshijun@vmware.com>
Co-authored-by: Wang Yan <wangyan@vmware.com>

Sort user and usergroup by most match order (goharbor#18273)

fixes goharbor#17859

Signed-off-by: stonezdj <daojunz@vmware.com>

Update the replication rule related to the Chartmuseum (goharbor#18274)

Update the registry and replication rule related to the Chartmuseum

Update replication_policy and registry as Harbor v2.8.0 deprecates chartmuseum.
Harbor deprecates chartmuseum as of v2.8.0
Epic: goharbor#17958
Discussion: goharbor#15057

Signed-off-by: Yang Jiao <jiaoya@vmware.com>

refactor: refact the webhook API and life process (goharbor#18255)

refactor: refact the notification job API and life process

1. Introduce new APIs for webhook jobs management.
2. Refact legacy APIs for backforward compatible.
3. Migrate the webhook jobs process to unified execution/task framework.

Closes: goharbor#18210

Signed-off-by: chlins <chenyuzh@vmware.com>

Add retry times for calling CVE data export execution list API (goharbor#18297)

1.Fixes goharbor#17879
2.Add retry times to avoid endless API calls for CVE data export execution list API

Signed-off-by: AllForNothing <sshijun@vmware.com>

Get job log by job_id in worker (goharbor#18261)

Get job by job_id in redis

  Get the last 10MB of data if it exceeds 10MB

Signed-off-by: stonezdj <daojunz@vmware.com>

Enhance webhook UI (goharbor#18291)

1. Add execution list for a certain webhook policy
  2. Add task list for a certain execution

Signed-off-by: AllForNothing <sshijun@vmware.com>

Update UI for the deprecation of Artifact Hub (goharbor#18303)

1. Update edit-registry page to enable the edition for Artifact Hub
2. Update edit-replication-rule page to enable the edition for rules contain Artifact Hub

Signed-off-by: AllForNothing <sshijun@vmware.com>

Add logs column for worker datagrid (goharbor#18307)

1. Related back-end PR goharbor#18261

Signed-off-by: AllForNothing <sshijun@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stonezdj stonezdj

Labels
area/API needs/triage triage issue before assigning target/2.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Sort user and usergroup by most match order stonezdj/harbor
3 participants
@stonezdj @wy65701436 @AllForNothing