Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the text for the oidc cli secret tooltip #18814

Merged
merged 1 commit into from
Jun 16, 2023

Conversation

AllForNothing
Copy link
Contributor

@AllForNothing AllForNothing commented Jun 13, 2023

  1. Update the text for all the i18n files

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

1. Update the text for all the i18n files

Signed-off-by: AllForNothing <sshijun@vmware.com>
@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Merging #18814 (57bc11b) into main (ca94a23) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 57bc11b differs from pull request most recent head e74ecd3. Consider uploading reports for the commit e74ecd3 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #18814      +/-   ##
==========================================
- Coverage   67.40%   67.40%   -0.01%     
==========================================
  Files         980      980              
  Lines      106883   106883              
  Branches     2671     2671              
==========================================
- Hits        72046    72045       -1     
- Misses      30959    30960       +1     
  Partials     3878     3878              
Flag Coverage Δ
unittests 67.40% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 8 files with indirect coverage changes

@AllForNothing AllForNothing added area/i18n Related to Translation changes. release-note/update Update or Fix labels Jun 13, 2023
Copy link
Contributor

@MinerYang MinerYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AllForNothing AllForNothing merged commit b822952 into goharbor:main Jun 16, 2023
WilfredAlmeida pushed a commit to WilfredAlmeida/harbor that referenced this pull request Jul 8, 2023
Update the text for oidc cli secret tooltip
1. Update the text for all the i18n files

Signed-off-by: AllForNothing <sshijun@vmware.com>
Signed-off-by: Wilfred Almeida <60785452+WilfredAlmeida@users.noreply.github.com>
WilfredAlmeida pushed a commit to WilfredAlmeida/harbor that referenced this pull request Jul 8, 2023
Update the text for oidc cli secret tooltip
1. Update the text for all the i18n files

Signed-off-by: AllForNothing <sshijun@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/i18n Related to Translation changes. release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants