Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix image name extraction #18992

Merged
merged 3 commits into from
Mar 30, 2024
Merged

fix image name extraction #18992

merged 3 commits into from
Mar 30, 2024

Conversation

tkatkov
Copy link
Contributor

@tkatkov tkatkov commented Jul 24, 2023

It also could be 'library/bitnami/fluentd:1.13.3-debian-10-r0' so we need to split resource to only 2 parts - possible namespace and image name which may include slashes for example - namespace: library, image: bitnami/fluentd:1.13.3-debian-10-r0

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@tkatkov tkatkov requested a review from a team as a code owner July 24, 2023 20:45
@MinerYang MinerYang assigned chlins and unassigned Vad1mo and OrlinVasilev Jul 31, 2023
@github-actions
Copy link

This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days.

@github-actions github-actions bot added the Stale label Sep 30, 2023
@chlins
Copy link
Member

chlins commented Oct 13, 2023

@tkatkov Hi, thanks for your catch, could you please add the unit tests to cover the multiple cases for this function?

@github-actions github-actions bot removed the Stale label Oct 13, 2023
@tkatkov
Copy link
Contributor Author

tkatkov commented Oct 13, 2023

@chlins tests added, thanks!

@chlins
Copy link
Member

chlins commented Oct 14, 2023

Please fix the CI DCO, sign off your commit. e.g git commit -s -m "xxx"

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins chlins added the release-note/update Update or Fix label Oct 14, 2023
@codecov
Copy link

codecov bot commented Oct 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.26%. Comparing base (b7b8847) to head (ff89850).
Report is 105 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #18992       +/-   ##
===========================================
- Coverage   67.56%   45.26%   -22.30%     
===========================================
  Files         991      244      -747     
  Lines      109181    13345    -95836     
  Branches     2719     2724        +5     
===========================================
- Hits        73768     6041    -67727     
+ Misses      31449     7003    -24446     
+ Partials     3964      301     -3663     
Flag Coverage Δ
unittests 45.26% <ø> (-22.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1235 files with indirect coverage changes

Copy link

This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days.

@github-actions github-actions bot added Stale and removed Stale labels Dec 18, 2023
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days.

@github-actions github-actions bot added the Stale label Mar 30, 2024
It also could be 'library/bitnami/fluentd:1.13.3-debian-10-r0' so we need to split resource to only 2 parts - possible namespace and image name which may include slashes for example -
namespace: library, image: bitnami/fluentd:1.13.3-debian-10-r0

Signed-off-by: Taras Katkov <[email protected]>
Adding namespace and resource extraction tests.

Signed-off-by: Taras Katkov <[email protected]>
Signed-off-by: Taras Katkov <[email protected]>
@chlins chlins enabled auto-merge (squash) March 30, 2024 13:06
@chlins chlins merged commit da3c85b into goharbor:main Mar 30, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants