Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/bmatcuk/doublestar from 1.1.1 to 1.3.4 in /src #19698

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 11, 2023

Bumps github.com/bmatcuk/doublestar from 1.1.1 to 1.3.4.

Release notes

Sourced from github.com/bmatcuk/doublestar's releases.

Fixed Minor Recursion Bug

Thanks @​pavelbazika!

Close Directories Immediately

A small change to close directories immediately, rather than deferring. Thanks @​luhring!

Fixed bug clobbering results if Readdir fails

If Readdir failed, doublestar was returning nil instead of the accumulated results. Thanks for the bug report @​InfiniteTF!

Fixed bug matching files that started with a multi-byte unicode char

Thanks @​bnkai for the bug report!

Added "OS" interface to improve testability

Thanks to @​twpayne, doublestar now has exported versions of PathMatch and Glob (PathMatchOS and GlobOS respectively) that take an OS interface which can be used to abstract the underlying filesystem calls. Using something like go-vfs, you can then write unit tests for code that uses doublestar without depending on an actual filesystem.

Existing PathMatch and Glob are unchanged.

Sort results from Glob()

No release notes provided.

Minor Bug Fix

Improves compatibility with path.Match by supporting something like Match("*/", "a/")

Windows Absolute Paths Without Volumes; Windows Tests Fixes

Thanks @​idoru!

Fixes Patterns that Start With Alternatives

Small bug fix release.

Support for path separators inside {alts}

This release adds support for {alt} groups that include path separators, for example: {/tmp/test/example1,/tmp/test/example2}. It also adds support for nested alt groups. This should close bug #25.

UNC Support

Support for UNC paths in Glob(). Thanks @​WithoutPants!

Removes Automatic Multi-Separator Clean-up Code

v1.1.2 introduced some code that would automatically clean-up multiple separators in patterns and paths (ie, /path/to//something would automatically get cleaned to /path/to/something by treating the // as /). However, it has been brought to my attention that this is not always desirable and, so, it makes sense to remove it. If this is desirable behavior, you could always cleanup your patterns and paths before passing them to doublestar, but if I leave in this code and it is undesirable, you have no option to change the behavior.

Fix Directory Issues on Windows

Windows didn't like some of the stuff in the test directory, so I've removed that from the repo and generate it on-the-fly when the tests run.

Fixed Some Corner Cases

Fixed a few corner cases where doublestar did not return the same result as golang's built-in Match functions. Since doublestar is meant to be a drop-in replacement, it should produce the same results.

Thanks @​storyicon for submitting the bug report!

Commits
  • ec92414 🐛 fix small recursion error
  • eb4d9ac Add example executable entrypoint
  • fbc9ddc Close dir immediately after contents are read
  • 5cf9061 🐛 don't throw away results if Readdir fails
  • bcc22aa [fix #40] 🐛 filename starting with unicode doesn't match *
  • 1a01b95 README adjustments
  • 6611e8e build on linux + windows
  • 23e080d test last three golang versions
  • 39df92f return any error from Close if no other error has occurred
  • 28ecce1 don't ignore errors from Readdir
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from a team as a code owner December 11, 2023 11:16
@dependabot dependabot bot added the release-note/update Update or Fix label Dec 11, 2023
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (41adc75) 67.55% compared to head (7957fd6) 67.56%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #19698      +/-   ##
==========================================
+ Coverage   67.55%   67.56%   +0.01%     
==========================================
  Files         991      991              
  Lines      109168   109168              
  Branches     2719     2719              
==========================================
+ Hits        73745    73763      +18     
+ Misses      31456    31439      -17     
+ Partials     3967     3966       -1     
Flag Coverage Δ
unittests 67.56% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes

@dependabot dependabot bot force-pushed the dependabot/go_modules/src/github.com/bmatcuk/doublestar-1.3.4 branch 2 times, most recently from 0256193 to 02aa4e8 Compare December 19, 2023 06:21
Bumps [github.com/bmatcuk/doublestar](https://github.com/bmatcuk/doublestar) from 1.1.1 to 1.3.4.
- [Release notes](https://github.com/bmatcuk/doublestar/releases)
- [Commits](bmatcuk/doublestar@v1.1.1...v1.3.4)

---
updated-dependencies:
- dependency-name: github.com/bmatcuk/doublestar
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/go_modules/src/github.com/bmatcuk/doublestar-1.3.4 branch from 02aa4e8 to b43b467 Compare December 19, 2023 09:08
@zyyw zyyw merged commit 2f2a646 into main Dec 20, 2023
19 checks passed
@dependabot dependabot bot deleted the dependabot/go_modules/src/github.com/bmatcuk/doublestar-1.3.4 branch December 20, 2023 05:34
altynbaev pushed a commit to altynbaev/harbor that referenced this pull request Jan 29, 2024
…bor#19698)

Bumps [github.com/bmatcuk/doublestar](https://github.com/bmatcuk/doublestar) from 1.1.1 to 1.3.4.
- [Release notes](https://github.com/bmatcuk/doublestar/releases)
- [Commits](bmatcuk/doublestar@v1.1.1...v1.3.4)

---
updated-dependencies:
- dependency-name: github.com/bmatcuk/doublestar
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Shengwen YU <[email protected]>
Signed-off-by: Altynbaev Dinislam <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants