Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump golang 1.21.5 & fix golangci-lint error #19722

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

MinerYang
Copy link
Contributor

@MinerYang MinerYang commented Dec 18, 2023

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

#19719

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@MinerYang MinerYang added the release-note/update Update or Fix label Dec 18, 2023
@MinerYang MinerYang requested a review from a team as a code owner December 18, 2023 01:57
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Merging #19722 (800c5b0) into main (5f828ea) will increase coverage by 0.00%.
The diff coverage is 60.16%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #19722   +/-   ##
=======================================
  Coverage   67.55%   67.55%           
=======================================
  Files         991      991           
  Lines      109175   109168    -7     
  Branches     2719     2719           
=======================================
  Hits        73752    73752           
+ Misses      31456    31448    -8     
- Partials     3967     3968    +1     
Flag Coverage Δ
unittests 67.55% <60.16%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/common/security/secret/context.go 93.75% <100.00%> (ø)
src/common/utils/uaa/fake_client.go 94.00% <100.00%> (ø)
src/controller/artifact/annotation/v1alpha1.go 64.81% <100.00%> (ø)
src/controller/artifact/processor/chart/chart.go 61.76% <100.00%> (ø)
src/controller/artifact/processor/cnab/cnab.go 58.06% <100.00%> (ø)
src/controller/artifact/processor/default.go 54.76% <100.00%> (ø)
src/controller/artifact/processor/image/index.go 69.23% <100.00%> (ø)
...controller/artifact/processor/image/manifest_v1.go 69.56% <100.00%> (ø)
...controller/artifact/processor/image/manifest_v2.go 71.21% <100.00%> (ø)
src/controller/artifact/processor/wasm/wasm.go 66.21% <100.00%> (ø)
... and 117 more

... and 4 files with indirect coverage changes

@MinerYang MinerYang changed the title bump golang 1.21.5 bump golang 1.21.5 & fix goalngci-lint error Dec 18, 2023
@MinerYang MinerYang changed the title bump golang 1.21.5 & fix goalngci-lint error bump golang 1.21.5 & fix golangci-lint error Dec 18, 2023
update golangci-lint && fix revive error

fix white space lint

Signed-off-by: yminer <[email protected]>
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wy65701436 wy65701436 merged commit b38de22 into goharbor:main Dec 19, 2023
17 of 18 checks passed
altynbaev pushed a commit to altynbaev/harbor that referenced this pull request Jan 29, 2024
bump golang 1.21.5

update golangci-lint && fix revive error

fix white space lint

Signed-off-by: yminer <[email protected]>
Signed-off-by: Altynbaev Dinislam <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants