Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OpenAPI Specification structural error #19782

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

blueswen
Copy link
Contributor

@blueswen blueswen commented Jan 2, 2024

Comprehensive Summary of your change

The reference definition SchedulerStatus already has type: object, so remove the duplicated type: object under schema which cause the structural error.

Issue being fixed

Fixes #19781

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Signed-off-by: Blueswen <[email protected]>
@blueswen blueswen requested a review from a team as a code owner January 2, 2024 13:54
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e397e86) 67.54% compared to head (9ec7493) 67.55%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #19782   +/-   ##
=======================================
  Coverage   67.54%   67.55%           
=======================================
  Files         991      991           
  Lines      109167   109165    -2     
  Branches     2719     2719           
=======================================
+ Hits        73742    73746    +4     
+ Misses      31461    31453    -8     
- Partials     3964     3966    +2     
Flag Coverage Δ
unittests 67.55% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

@wy65701436 wy65701436 added the release-note/update Update or Fix label Jan 3, 2024
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wy65701436 wy65701436 merged commit 0d157f2 into goharbor:main Jan 3, 2024
13 of 14 checks passed
altynbaev pushed a commit to altynbaev/harbor that referenced this pull request Jan 29, 2024
Fix structural error

Signed-off-by: Blueswen <[email protected]>
Signed-off-by: Altynbaev Dinislam <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenAPI Specification Structural Error
5 participants