Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quota permissions to robot account #19799

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

YangJiao0817
Copy link
Member

Fix #19792

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (de7ea28) 67.55% compared to head (48532d8) 67.55%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #19799      +/-   ##
==========================================
- Coverage   67.55%   67.55%   -0.01%     
==========================================
  Files         991      991              
  Lines      109165   109165              
  Branches     2719     2719              
==========================================
- Hits        73747    73745       -2     
- Misses      31453    31454       +1     
- Partials     3965     3966       +1     
Flag Coverage Δ
unittests 67.55% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ide-nav/system-robot-accounts/system-robot-util.ts 64.06% <ø> (ø)

... and 5 files with indirect coverage changes

@YangJiao0817 YangJiao0817 enabled auto-merge (squash) January 5, 2024 06:59
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@YangJiao0817 YangJiao0817 merged commit 64a2296 into goharbor:main Jan 8, 2024
11 of 12 checks passed
altynbaev pushed a commit to altynbaev/harbor that referenced this pull request Jan 29, 2024
Fix goharbor#19792

Signed-off-by: Yang Jiao <[email protected]>
Co-authored-by: Yang Jiao <[email protected]>
Signed-off-by: Altynbaev Dinislam <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Robot accounts still does not have full permissions
5 participants