Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cherry-Pick] Update replication rule filter label xpath (#19895) #19904

Merged
merged 1 commit into from
Jan 25, 2024
Merged

[Cherry-Pick] Update replication rule filter label xpath (#19895) #19904

merged 1 commit into from
Jan 25, 2024
+1 −1

Conversation

zyyw
Copy link
Contributor

@zyyw zyyw commented Jan 24, 2024

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@zyyw zyyw added release-note/infra Infra related changes e.g. release, test, ship etc... target/2.10.1 labels Jan 24, 2024
@zyyw zyyw requested a review from a team as a code owner January 24, 2024 09:16
@zyyw zyyw force-pushed the release-2.10.0-replication_rule_filter_label_xpath branch from f77d597 to 410c8b0 Compare January 24, 2024 09:17
chlins
chlins approved these changes Jan 25, 2024
View reviewed changes
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zyyw zyyw merged commit 4694d88 into goharbor:release-2.10.0 Jan 25, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chlins chlins chlins approved these changes

@YangJiao0817 YangJiao0817 YangJiao0817 approved these changes

Assignees

@wy65701436 wy65701436

@AllForNothing AllForNothing

@MinerYang MinerYang

@YangJiao0817 YangJiao0817

Labels
release-note/infra Infra related changes e.g. release, test, ship etc... target/2.10.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@zyyw @chlins @YangJiao0817 @wy65701436 @AllForNothing @MinerYang