Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ip_family config in harbor.yml on release-2.10 #19939

Merged

Conversation

MinerYang
Copy link
Contributor

@MinerYang MinerYang commented Feb 2, 2024

Issue being fixed

#19932

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1f8e578) 67.55% compared to head (80576a1) 67.54%.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-2.10.0   #19939      +/-   ##
==================================================
- Coverage           67.55%   67.54%   -0.02%     
==================================================
  Files                 991      991              
  Lines              109181   109181              
  Branches             2719     2719              
==================================================
- Hits                73758    73742      -16     
- Misses              31457    31470      +13     
- Partials             3966     3969       +3     
Flag Coverage Δ
unittests 67.54% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

Signed-off-by: yminer <[email protected]>

update name

update prepare and migration

update comments

Signed-off-by: yminer <[email protected]>

remove print msg

update migrate template

update default value

update migrate template
@MinerYang MinerYang force-pushed the add_ipFamily_config_release-2.10 branch from 858b090 to 80576a1 Compare February 2, 2024 06:10
@zyyw
Copy link
Contributor

zyyw commented Feb 2, 2024

@MinerYang please see my comment in this PR:

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MinerYang MinerYang changed the title add ip_family config in values.yaml on release-2.10 add ip_family config in harbor.yml on release-2.10 Feb 2, 2024
@stonezdj stonezdj merged commit 158718c into goharbor:release-2.10.0 Feb 2, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants