Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh base images on release-2.9.0 #20005

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

zyyw
Copy link
Contributor

@zyyw zyyw commented Feb 21, 2024

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@zyyw zyyw added the release-note/infra Infra related changes e.g. release, test, ship etc... label Feb 21, 2024
@zyyw zyyw requested a review from a team as a code owner February 21, 2024 07:29
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ce85f47) 67.41% compared to head (38c36e3) 44.83%.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-2.9.0   #20005       +/-   ##
==================================================
- Coverage          67.41%   44.83%   -22.59%     
==================================================
  Files                993      244      -749     
  Lines             108982    13417    -95565     
  Branches            2752     2752               
==================================================
- Hits               73471     6015    -67456     
+ Misses             31547     7098    -24449     
+ Partials            3964      304     -3660     
Flag Coverage Δ
unittests 44.83% <ø> (-22.59%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 753 files with indirect coverage changes

Copy link

@yanji09 yanji09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@MinerYang MinerYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zyyw zyyw merged commit 3356196 into goharbor:release-2.9.0 Feb 21, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/infra Infra related changes e.g. release, test, ship etc...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants