Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move strong_ssl_ciphers to top level in harbor.yml #20021

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

stonezdj
Copy link
Contributor

@stonezdj stonezdj commented Feb 23, 2024

fixes #19912

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.41%. Comparing base (b622d4a) to head (c4e5235).
Report is 24 commits behind head on release-2.9.0.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-2.9.0   #20021      +/-   ##
=================================================
- Coverage          67.42%   67.41%   -0.01%     
=================================================
  Files                993      993              
  Lines             108932   108990      +58     
  Branches            2752     2752              
=================================================
+ Hits               73444    73473      +29     
- Misses             31534    31555      +21     
- Partials            3954     3962       +8     
Flag Coverage Δ
unittests 67.41% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 15 files with indirect coverage changes

@stonezdj stonezdj changed the title [cherry-pick] Move strong_ssl_ciphers to top level in harbor.yaml Move strong_ssl_ciphers to top level in harbor.yaml Feb 23, 2024
@stonezdj stonezdj changed the title Move strong_ssl_ciphers to top level in harbor.yaml Move strong_ssl_ciphers to top level in harbor.yml Feb 23, 2024
@stonezdj stonezdj enabled auto-merge (squash) February 23, 2024 08:08
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj stonezdj merged commit 5b78c3f into goharbor:release-2.9.0 Feb 26, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants