Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update support for artifactType for both manifest and index #20030

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Update support for artifactType for both manifest and index #20030

merged 1 commit into from
Mar 12, 2024

Conversation

MinerYang
Copy link
Contributor

@MinerYang MinerYang commented Feb 26, 2024 •
edited by Vad1mo

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@MinerYang MinerYang added the release-note/update Update or Fix label Feb 26, 2024
@MinerYang MinerYang requested a review from a team as a code owner February 26, 2024 02:39
@MinerYang MinerYang force-pushed the support_artifactype_empty_config branch from ed4105a to 6fee156 Compare February 26, 2024 03:26
@MinerYang MinerYang assigned wy65701436 and unassigned Vad1mo and OrlinVasilev Feb 26, 2024
@MinerYang MinerYang force-pushed the support_artifactype_empty_config branch 2 times, most recently from 7d77aa7 to c2e6bf1 Compare February 26, 2024 07:53
@MinerYang MinerYang changed the title Update support for artifactType when config mediatype is empty Update support for artifactType for both manifest and index Feb 26, 2024
chlins
chlins approved these changes Feb 27, 2024
View reviewed changes
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MinerYang MinerYang changed the title Update support for artifactType for both manifest and index [WIP]Update support for artifactType for both manifest and index Feb 27, 2024
@MinerYang MinerYang force-pushed the support_artifactype_empty_config branch from c2e6bf1 to 4860ee6 Compare February 27, 2024 10:36
@MinerYang MinerYang force-pushed the support_artifactype_empty_config branch 2 times, most recently from e5b9388 to 5694f87 Compare February 29, 2024 06:50
wy65701436
wy65701436 approved these changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MinerYang MinerYang changed the title [WIP]Update support for artifactType for both manifest and index Update support for artifactType for both manifest and index Mar 1, 2024
@MinerYang MinerYang force-pushed the support_artifactype_empty_config branch 2 times, most recently from 3ef4ef7 to cdf67bf Compare March 1, 2024 07:22
@MinerYang MinerYang mentioned this pull request Mar 1, 2024
Closed
@MinerYang MinerYang force-pushed the support_artifactype_empty_config branch from cdf67bf to 0a94b5c Compare March 1, 2024 07:34
@MinerYang MinerYang mentioned this pull request Mar 1, 2024
Closed
5 tasks
@Vad1mo Vad1mo enabled auto-merge (squash) March 5, 2024 19:02
@MinerYang MinerYang force-pushed the support_artifactype_empty_config branch from 53b01e1 to 9ca96ad Compare March 10, 2024 15:06
@MinerYang
add artifact_type for artifact model to support artifactType filter
32fb34a 
Signed-off-by: yminer <[email protected]>

add 2.11 sql schema & update index artifactType omitted

Signed-off-by: yminer <[email protected]>

update UT

update migrate sql for artifact_type

Signed-off-by: yminer <[email protected]>

remove debug line

update subject middleware when push acccesory of acessory & using artifactType

update UT test insert artifact sql
@MinerYang MinerYang force-pushed the support_artifactype_empty_config branch from 9ca96ad to 32fb34a Compare March 12, 2024 13:15
@Vad1mo Vad1mo merged commit a269b4f into goharbor:main Mar 12, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wy65701436 wy65701436 wy65701436 approved these changes

@chlins chlins chlins approved these changes

Assignees

@wy65701436 wy65701436

@zyyw zyyw

@chlins chlins

Labels
kind/distribution-spec release-note/update Update or Fix target/2.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@MinerYang @wy65701436 @chlins @Vad1mo @zyyw @OrlinVasilev