Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update go.mod (vendor) & golangci-lint & mocks #20070

Merged

Conversation

zyyw
Copy link
Contributor

@zyyw zyyw commented Feb 29, 2024

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Signed-off-by: Shengwen Yu <[email protected]>
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 61.40351% with 110 lines in your changes are missing coverage. Please review.

Project coverage is 67.42%. Comparing base (2196ba7) to head (b4103ad).

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-2.9.0   #20070      +/-   ##
=================================================
- Coverage          67.42%   67.42%   -0.01%     
=================================================
  Files                993      993              
  Lines             108990   108981       -9     
  Branches            2752     2752              
=================================================
- Hits               73491    73477      -14     
- Misses             31540    31545       +5     
  Partials            3959     3959              
Flag Coverage Δ
unittests 67.42% <61.40%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/common/rbac/project/evaluator.go 67.92% <100.00%> (ø)
src/common/security/secret/context.go 93.75% <100.00%> (ø)
src/common/utils/uaa/fake_client.go 94.00% <100.00%> (ø)
src/controller/artifact/annotation/v1alpha1.go 64.81% <100.00%> (ø)
src/controller/artifact/processor/chart/chart.go 61.76% <100.00%> (ø)
src/controller/artifact/processor/cnab/cnab.go 58.06% <100.00%> (ø)
src/controller/artifact/processor/default.go 71.42% <100.00%> (ø)
src/controller/artifact/processor/image/index.go 69.23% <100.00%> (ø)
...controller/artifact/processor/image/manifest_v1.go 69.56% <100.00%> (ø)
...controller/artifact/processor/image/manifest_v2.go 71.21% <100.00%> (ø)
... and 132 more

... and 4 files with indirect coverage changes

@zyyw zyyw changed the title fix: update go.mod fix: update go.mod (vendor) & golangci-lint & mocks Mar 1, 2024
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zyyw zyyw closed this Mar 1, 2024
@zyyw zyyw reopened this Mar 1, 2024
Copy link
Contributor

@stonezdj stonezdj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wy65701436 wy65701436 merged commit f65d238 into goharbor:release-2.9.0 Mar 4, 2024
30 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants