Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go-bindata repo name and URL #152

Closed
wants to merge 1 commit into from
Closed

Update go-bindata repo name and URL #152

wants to merge 1 commit into from

Conversation

danielparks
Copy link

jteeuwen/go-bindata → go-bindata/go-bindata

@coveralls
Copy link

coveralls commented Jan 13, 2019

Pull Request Test Coverage Report for Build 275

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 59.188%

Totals Coverage Status
Change from base Build 274: 0.0%
Covered Lines: 773
Relevant Lines: 1306

💛 - Coveralls

Copy link
Member

@dhui dhui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dependencies (managed by dep for Go 1.10.x and Go modules for Go 1.11.x) need to be updated as well. Have you verified that the fork hasn't introduced a backwards incompatible change?

@dhui
Copy link
Member

dhui commented Jan 14, 2019

Are any forks of go-bindata actively maintained? go-bindata/go-bindata#16

A list of forks was being tracked here: a-urth/go-bindata#1
But that repo is now archived, so that issue won't be updated anymore...

The whole go-bindata pkg forks has been kind of a mess...
gofrs/help-requests#7
At a cursory look, this fork seems to be more actively maintained than the others: https://github.com/kevinburke/go-bindata

Since the future of go-bindata is unclear, I'm not sure what value is added by updating the go-bindata dependency in migrate.
I think a better approach for migrate would be to clean up this PR to support multiple bin packers and for users to migrate (on their own time-frame) to a different bin packer that's actively maintained.

@danielparks
Copy link
Author

Eh. Seems reasonable. I'm not going to be able to test this for quite some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants