Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clickhouse: make table engine for schema versions table configurable #551

Merged
merged 6 commits into from
Apr 22, 2021

Conversation

brunotm
Copy link
Contributor

@brunotm brunotm commented Apr 21, 2021

This change adds the x-table-engine parameter to choose the default table engine for the schema versions table. Defaults to the current one "TinyLog".

Fixes #505

shinoys222
shinoys222 previously approved these changes Apr 21, 2021
@coveralls
Copy link

coveralls commented Apr 21, 2021

Pull Request Test Coverage Report for Build 305

  • 13 of 13 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 57.297%

Totals Coverage Status
Change from base Build 294: 0.06%
Covered Lines: 3510
Relevant Lines: 6126

💛 - Coveralls

Copy link
Member

@dhui dhui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

database/clickhouse/clickhouse.go Show resolved Hide resolved
database/clickhouse/clickhouse_test.go Outdated Show resolved Hide resolved
Copy link
Member

@dhui dhui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the PR feedback!

database/clickhouse/README.md Outdated Show resolved Hide resolved
database/clickhouse/README.md Outdated Show resolved Hide resolved
database/clickhouse/clickhouse.go Outdated Show resolved Hide resolved
database/clickhouse/clickhouse.go Outdated Show resolved Hide resolved
database/clickhouse/clickhouse_test.go Outdated Show resolved Hide resolved
Copy link
Member

@dhui dhui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the PR feedback!

@dhui dhui merged commit 4720914 into golang-migrate:master Apr 22, 2021
@brunotm
Copy link
Contributor Author

brunotm commented Apr 22, 2021

@dhui thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change Engine=TinyLog to Engine=MergeTree for MigrationsTable
4 participants