add happy path test + readme

internal/gps/_testdata/badrepo/README.md

@@ -0,0 +1,5 @@
+### Test Data
+
+This directory contains artifacts that represent malformed repo archives. Its purpose is to ensure `dep` can recover from such corrupted repositories in specific test scenarios.
+
+- `corrupt_dot_git_directory.tar`: is a repo with a corrupt `.git` directory. Dep can put a directory in such malformed state when a user hits `Ctrl+C` in the middle of a `dep init` process or others. `TestNewCtxRepoRecovery` uses this file to ensure recovery.

internal/gps/vcs_repo.go

@@ -31,7 +31,7 @@ func newCtxRepo(s vcs.Type, ustr, path string) (r ctxRepo, err error) {
 		// then the local repo is in an incorrect state. Remove and
 		// treat it as a new not-yet-cloned repo.
 
-		// TODO(marwan-at-work): pass a logger here to warn/give progress of the above comment.
+		// TODO(marwan-at-work): warn/give progress of the above comment.
 		os.RemoveAll(path)
 		r, err = getVCSRepo(s, ustr, path)
 	}

internal/gps/vcs_repo_test.go

@@ -52,10 +52,30 @@ func TestErrs(t *testing.T) {
 	}
 }
 
-func TestNewCtxRepo(t *testing.T) {
+func TestNewCtxRepoHappyPath(t *testing.T) {
 	t.Parallel()
 
-	tempDir, err := ioutil.TempDir("", "go-ctx-repo-test")
+	tempDir, err := ioutil.TempDir("", "go-ctx-repo-recovery-test")
+	if err != nil {
+		t.Fatal(err)
+	}
+	defer func() {
+		err = os.RemoveAll(tempDir)
+		if err != nil {
+			t.Error(err)
+		}
+	}()
+
+	_, err = newCtxRepo(vcs.Git, gitRemoteTestRepo, tempDir)
+	if err != nil {
+		t.Fatal(err)
+	}
+}
+
+func TestNewCtxRepoRecovery(t *testing.T) {
+	t.Parallel()
+
+	tempDir, err := ioutil.TempDir("", "go-ctx-repo-recovery-test")
 	if err != nil {
 		t.Fatal(err)
 	}
@@ -71,7 +91,7 @@ func TestNewCtxRepo(t *testing.T) {
 		t.Fatal(err)
 	}
 
-	src := filepath.Join(cwd, "_testdata", "src", "corrupt", "corrupt_dot_git_directory.tar")
+	src := filepath.Join(cwd, "_testdata", "badrepo", "corrupt_dot_git_directory.tar")
 	f, err := os.Open(src)
 	if err != nil {
 		t.Fatal(err)