-
Notifications
You must be signed in to change notification settings - Fork 1k
README: clarify deprecation and point to modules #2253
Conversation
Oh, the docs site is also in the master branch. I'll fix that here too. |
31be684
to
2ebfb6c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I think the Feedback and Contributing sections should be
deleted from the README. Installing is still relevant since it's
possible to download an archived repository, but it won't be possible
to give feedback or contribute.
You both raise good points :) I'll update the commit. Also, of course CI is required to merge, and it's broken... we'll have to wait for @andybons to grant one of us admin access to be able to push to master. |
Indeed, the build is broken, so I've just disabled the hard requirement on the travis-ci check for merges. Now it should allow the merge even if the travis-ci build failed. |
768d5d1
to
bfc2b6d
Compare
bfc2b6d
to
14974a6
Compare
I ended up with |
I've also deleted both of those sections. Merging - thanks both for the reviews! |
It looks like actually updating the generated gh-pages branch is a manual process, last done in 2018. I'll try to figure out how to do it and push there. |
Alright, done: 7afd7b6 All that I did boiled down to:
There are other changes applied to the generated pages aside from this PR, which I attribute to the long time it's been since anyone ran the tool. They all seem minor, though. |
See golang/go#38158.