Preliminary status command #8
Conversation
This is the minimum amount necessary to get a SourceManager working.
Mostly just a helper function that pulls together the basic info we need for most commands.
This is hardly complete, particularly given the empty collectConstraints() func and the fact that our manifests and locks don't really support working with actual code yet. Nevertheless, it is at least a strong demonstration of how one goes about collecting the relevant information.
|
Aside from my one comment, just 👍 this and merge it. We can revisit later IMO. |
|
|
||
| type project struct { | ||
| root string | ||
| pr gps.ProjectRoot |
There was a problem hiding this comment.
What is a root (string) and a projectRoot ? What makes them different?
There was a problem hiding this comment.
yeah, i should name the vars better so that it's clearer.
root is a string that describes the absolute path to the root of the repository. a ProjectRoot, istype ProjectRoot string, but is specifically intended to be an import path that corresponds to the root of a project/repository.
I'm not entirely happy with doing things this way, but as the linked docs note, I did it because being clear about when a string is expected to have the specific properties of being a root project import path, vs just an fs path, vs any import path, are so muddled in a lot of this domain that i wanted a stronger signaling mechanism to implementors about when we needed this type of thing in particular.
|
hmm. i pushed some new commits, but during a github availability flap...it appears to have missed out on picking them up and showing them here, even though they're in the repo |
|
nvm, there they are, didn't show until i commented. weird. |
make lint most happy
Preliminary status command
Preliminary status command
This is a preliminary implementation of a status command. (It includes everything in #7, and supercedes it so i'm closing that PR), but does kinda sorta the basics. Or could. Right now, it basically just does the setup :)