Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build: add tip builders with GOEXPERIMENT=aliastypeparams=1 for at least go and x/tools repo #69121

Closed
timothy-king opened this issue Aug 28, 2024 · 3 comments
Closed

x/build: add tip builders with GOEXPERIMENT=aliastypeparams=1 for at least go and x/tools repo #69121

timothy-king opened this issue Aug 28, 2024 · 3 comments
Assignees
@timothy-king
Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@timothy-king
Copy link
Contributor

timothy-king commented Aug 28, 2024 •
edited
Loading

Add a builder for >=1.24 with GOEXPERIMENT=aliastypeparams=1 for additional test coverage (#46477). aliastypeparams was introduced in 1.23. Its default is currently off. For the 1.24 release, we want to flip this to default to on.

For packages that use go/types, this also requires GODEBUG=gotypesalias=1. This includes x/tools.

We do not expect <= 1.23 to fully work with type parameterized aliases. (1.23 only supported these as a 'preview'.) The builders for #68798 (GODEBUG=gotypesalias=1) are enabled at 1.22 and 1.23. So these configurations are not expected to overlap smoothly.
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Aug 28, 2024
@gopherbot gopherbot added this to the Unreleased milestone Aug 28, 2024
@timothy-king timothy-king self-assigned this Aug 28, 2024
@gabyhelp
Copy link

Related Issues and Documentation

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/609375 mentions this issue: main.star: add aliastypeparams builders

@dmitshur dmitshur added the NeedsFix The path to resolution is known, but the work has not been done. label Aug 29, 2024
gopherbot pushed a commit to golang/build that referenced this issue Aug 29, 2024
@timothy-king
main.star: add aliastypeparams builders
22bbf71 
For golang/go#69121

Change-Id: Ia3183c1037384ee36b1afe174f70fa9cfda12f86
Reviewed-on: https://go-review.googlesource.com/c/build/+/609375
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/609735 mentions this issue: main.star: enable aliastypeparams builders on presubmit and postsubmit

gopherbot pushed a commit to golang/build that referenced this issue Sep 6, 2024
@timothy-king
main.star: enable aliastypeparams builders on presubmit and postsubmit
9bb6fe5 
For golang/go#69121

Change-Id: Ia47ba04ed86cf1785edaddd689c53065f4a83d87
Reviewed-on: https://go-review.googlesource.com/c/build/+/609735
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timothy-king timothy-king

Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Release
Archived in project
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@timothy-king @dmitshur @gopherbot @gabyhelp