Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/vulndb: potential Go vuln in github.com/sigstore/gitsign: CVE-2023-47122 #2332

Closed
GoVulnBot opened this issue Nov 10, 2023 · 4 comments
Assignees
Labels
excluded: EFFECTIVELY_PRIVATE This vulnerability exists in a package can be imported, but isn't meant to be outside that module.

Comments

@GoVulnBot
Copy link

CVE-2023-47122 references github.com/sigstore/gitsign, which may be a Go module.

Description:
Gitsign is software for keyless Git signing using Sigstore. In versions of gitsign starting with 0.6.0 and prior to 0.8.0, Rekor public keys were fetched via the Rekor API, instead of through the local TUF client. If the upstream Rekor server happened to be compromised, gitsign clients could potentially be tricked into trusting incorrect signatures. There is no known compromise the default public good instance (rekor.sigstore.dev) - anyone using this instance is unaffected. This issue was fixed in v0.8.0. No known workarounds are available.

References:

Cross references:
No existing reports found with this module or alias.

See doc/triage.md for instructions on how to triage this report.

modules:
    - module: github.com/sigstore/gitsign
      vulnerable_at: 0.8.0
      packages:
        - package: gitsign
cves:
    - CVE-2023-47122
references:
    - advisory: https://github.com/sigstore/gitsign/security/advisories/GHSA-xvrc-2wvh-49vc
    - fix: https://github.com/sigstore/gitsign/pull/399
    - fix: https://github.com/sigstore/gitsign/commit/cd66ccb03c86a3600955f0c15f6bfeb75f697236
    - web: https://docs.sigstore.dev/about/threat-model/#sigstore-threat-model

@zpavlinovic zpavlinovic self-assigned this Nov 15, 2023
@zpavlinovic
Copy link
Contributor

Vulnerability in tool. Moreover, no packages are imported.

@zpavlinovic zpavlinovic added the excluded: EFFECTIVELY_PRIVATE This vulnerability exists in a package can be imported, but isn't meant to be outside that module. label Nov 15, 2023
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/542555 mentions this issue: data/excluded: batch add 2 excluded reports

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/592763 mentions this issue: data/reports: unexclude 75 reports

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/606792 mentions this issue: data/reports: unexclude 20 reports (11)

gopherbot pushed a commit that referenced this issue Aug 21, 2024
  - data/reports/GO-2023-2097.yaml
  - data/reports/GO-2023-2109.yaml
  - data/reports/GO-2023-2121.yaml
  - data/reports/GO-2023-2125.yaml
  - data/reports/GO-2023-2134.yaml
  - data/reports/GO-2023-2135.yaml
  - data/reports/GO-2023-2136.yaml
  - data/reports/GO-2023-2156.yaml
  - data/reports/GO-2023-2159.yaml
  - data/reports/GO-2023-2166.yaml
  - data/reports/GO-2023-2170.yaml
  - data/reports/GO-2023-2176.yaml
  - data/reports/GO-2023-2188.yaml
  - data/reports/GO-2023-2329.yaml
  - data/reports/GO-2023-2330.yaml
  - data/reports/GO-2023-2332.yaml
  - data/reports/GO-2023-2335.yaml
  - data/reports/GO-2023-2336.yaml
  - data/reports/GO-2023-2337.yaml
  - data/reports/GO-2023-2338.yaml

Updates #2097
Updates #2109
Updates #2121
Updates #2125
Updates #2134
Updates #2135
Updates #2136
Updates #2156
Updates #2159
Updates #2166
Updates #2170
Updates #2176
Updates #2188
Updates #2329
Updates #2330
Updates #2332
Updates #2335
Updates #2336
Updates #2337
Updates #2338

Change-Id: I5fc55dacf7cdfd2512c00f07abfc0debfde9263f
Reviewed-on: https://go-review.googlesource.com/c/vulndb/+/606792
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Commit-Queue: Tatiana Bradley <tatianabradley@google.com>
Auto-Submit: Tatiana Bradley <tatianabradley@google.com>
Reviewed-by: Damien Neil <dneil@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
excluded: EFFECTIVELY_PRIVATE This vulnerability exists in a package can be imported, but isn't meant to be outside that module.
Projects
None yet
Development

No branches or pull requests

3 participants