Add block upload HIL test #584
Conversation
|
Visit the preview URL for this PR (updated for commit 1515ff8): https://golioth-firmware-sdk-doxygen-dev--pr584-szczys-add-blo-zj37n2l0.web.app (expires Wed, 18 Sep 2024 20:36:40 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: a9993e61697a3983f3479e468bcb0b616f9a0578 |
szczys
force-pushed
the
szczys/add-block-upload-hil-test
branch
3 times, most recently
from
e5c89c9
to
8ba6012
Compare
tests/hil/tests/stream/test.c
Outdated
| } | ||
| } | ||
|
|
||
| #define long_json \ |
There was a problem hiding this comment.
It would be cleaner to store this in a text file and a header file generated by xxd -i, checking in both. Then the python script can directly calculate the hash of the txt file. This way, the code is easier to read (no super long array in the source), and there are fewer hardcoded things since both the C and python are generating their data from the same source (the txt file).
There was a problem hiding this comment.
Great suggestion, thanks. I've updated to use this approach.
Update the python Golioth tools repository to include device stream.get() functionality needed for block upload HIL test. This commit must be update with a tag number once a new release of the tools repository is available. Signed-off-by: Mike Szczys <mike@golioth.io>
szczys
force-pushed
the
szczys/add-block-upload-hil-test
branch
2 times, most recently
from
082ea49
to
4089ad3
Compare
szczys
force-pushed
the
szczys/add-block-upload-hil-test
branch
from
4089ad3
to
fd1d4d2
Compare
|
ESP-IDF tests are failing to build |
This test uploads a large JSON string using block upload. The included pipeline must be enable in the firmware_ci project for proper data routing. The hash of the json object is checked to confirm successful upload. Signed-off-by: Mike Szczys <mike@golioth.io>
szczys
force-pushed
the
szczys/add-block-upload-hil-test
branch
from
fd1d4d2
to
1515ff8
Compare
Code Coverage
|
This PR adds
streamto the integration testing, with one task of testing block upload.firmware_cipython-golioth-toolstag once a release is cutresolves https://github.com/golioth/firmware-issue-tracker/issues/640