workflows: use safe-upload-artifacts throughout #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update all workflows to use safe-upload-artifacts whenever upload artifacts that may contain secrets. - Binary artifact uploads from build steps do not contain secrets and still use upload-artifact directly - The merge reports workflows combine artifacts that have already been uploaded (and therefor have already run through the safe upload) - Remove a few erroneous ids and retention settings Signed-off-by: Mike Szczys <mike@golioth.io>
|
Visit the preview URL for this PR (updated for commit 99b9a35): https://golioth-firmware-sdk-doxygen-dev--pr608-szczys-always-7oc5iqca.web.app (expires Thu, 26 Sep 2024 16:16:42 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: a9993e61697a3983f3479e468bcb0b616f9a0578 |
Code Coverage (Zephyr)
|
sam-golioth
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update all workflows to use safe-upload-artifacts whenever upload artifacts that may contain secrets.
resolves https://github.com/golioth/firmware-issue-tracker/issues/672