Skip to content

Commit

Permalink
fix(docker-build): correct image for docker.io builds
Browse files Browse the repository at this point in the history
  • Loading branch information
geertjanvdk committed Sep 7, 2023
1 parent a4ff1ee commit acc3665
Showing 1 changed file with 9 additions and 12 deletions.
21 changes: 9 additions & 12 deletions stock_docker.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import (
"math/rand"
"net/url"
"os/exec"
"strings"
)

var TargetDockerBuild = Target{
Expand Down Expand Up @@ -42,9 +43,8 @@ var TargetDockerBuild = Target{

if registry != "" {
// command line flag override default

if registry == "docker.io" || registry == "local" {
registry = ""
registry = "docker.io"
}

target.Flags["registry"] = registry
Expand All @@ -54,7 +54,12 @@ var TargetDockerBuild = Target{
fmt.Println("Note: registry not set, default docker.io/library will be used.")
}

if image != "" {
if target.Flags["registry"] == "docker.io" {
// correct image name (checked later when empty)
if image, ok := target.Flags["image"].(string); ok && image != "" {
target.Flags["image"] = "library/" + image[strings.LastIndex(image, "/")+1:]
}
} else if image != "" {
// command line flag override default
target.Flags["image"] = image
}
Expand Down Expand Up @@ -94,15 +99,7 @@ var TargetDockerBuild = Target{
}

execArgs := []string{"build", "--tag", tag, "."}

cmd := exec.Command("docker", execArgs...)
cmd.Stdout = target.Maker.StdOut
cmd.Stderr = target.Maker.StdErr
if target.WorkDir != "" {
fmt.Println("executing in directory:", target.WorkDir)
cmd.Dir = target.WorkDir
}
if err := cmd.Run(); err != nil {
if err := execDocker(target.Maker.StdOut, target.Maker.StdErr, execArgs, target.WorkDir); err != nil {
return err
}

Expand Down

0 comments on commit acc3665

Please sign in to comment.