Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EarlGrey 1.x | UITextView notifications are not triggered when using replaceText #771

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Simon-Kaz
Copy link

  • Updated replaceText to trigger UITextView notifications
  • added sample tests to exercise the changes
  • added a character counter label for simple assertions in the UI Tests.

… tests to exercise the changes and a character counter label for simple assertions
@@ -1,13 +1,17 @@
<?xml version="1.0" encoding="UTF-8"?>
<document type="com.apple.InterfaceBuilder3.CocoaTouch.XIB" version="3.0" toolsVersion="12121" systemVersion="16G29" targetRuntime="iOS.CocoaTouch" propertyAccessControl="none" useAutolayout="YES" colorMatched="NO">
<document type="com.apple.InterfaceBuilder3.CocoaTouch.XIB" version="3.0" toolsVersion="14313.18" targetRuntime="iOS.CocoaTouch" propertyAccessControl="none" useAutolayout="YES" colorMatched="YES">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I ask which Xcode you used? Just want to confirm.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xcode 10.0 on MacOS Mojave!

@tirodkar
Copy link
Collaborator

LG Otherwise! Thanks for this @Simon-Kaz !

@tirodkar
Copy link
Collaborator

@Simon-Kaz - would you mind sending this fix for EG 2 as well?

@Simon-Kaz
Copy link
Author

@Simon-Kaz - would you mind sending this fix for EG 2 as well?

I'll definitely try! :)

@Simon-Kaz
Copy link
Author

Hi @tirodkar , I've added the fix for EG2 as well. I also pushed a small fix for an incorrect selector just now, should be all good now 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants