Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controller in SimpleExoPlayerView is visible when I use app:use_controller="false" #1919

Closed
tprochazka opened this issue Oct 9, 2016 · 1 comment
Labels

Comments

@tprochazka
Copy link

When I use com.google.android.exoplayer2.ui.SimpleExoPlayerView with app:use_controller="false"
Controller stay visible all the time.
Tested o r2.0.2

Only workaround is use setUseController(false) but XML layout attribute must be removed too, otherwise setUseController(false) will have no impact and controll will be visible also after call setUseController(false) because of this method has this on the beginning

    if (this.useController == useController) {
      return;
    }
@ojw28 ojw28 added the bug label Oct 9, 2016
@ojw28
Copy link
Contributor

ojw28 commented Oct 9, 2016

We'll push a fix for this shortly; thanks!

ojw28 added a commit that referenced this issue Oct 11, 2016
- Make sure no events are posted on PlaybackControlView
  if it's not attached to a window. This can cause leaks.
  The target hide time is recorded if necessary and
  processed when the view is re-attached.
- Deduplicated PlaybackControlView.VisibilityListener
  invocations.
- Fixed timeouts to be more intuitive (I think).
- Fixed initial visibility of PlaybackControlView when
  used as part of SimpleExoPlayerView.
- Made some more attributes configurable from layout xml.

Issue: #1908
Issue: #1919
Issue: #1923

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=135679988
@ojw28 ojw28 closed this as completed Oct 11, 2016
@google google locked and limited conversation to collaborators Jun 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants