Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support CRYPTO_MODE_AES_CBC #1989

Closed
yanglichuan opened this issue Oct 25, 2016 · 4 comments
Closed

Support CRYPTO_MODE_AES_CBC #1989

yanglichuan opened this issue Oct 25, 2016 · 4 comments

Comments

@yanglichuan
Copy link

CRYPTO_MODE_AES_CBC = MediaCodec.CRYPTO_MODE_AES_CBC;

@ojw28 ojw28 changed the title MediaCodec.CRYPTO_MODE_AES_CBC; 找不到 Support CRYPTO_MODE_AES_CBC Oct 25, 2016
@ojw28
Copy link
Contributor

ojw28 commented Oct 25, 2016

We don't support CRYPTO_MODE_AES_CBC yet. Note that it's only available from API level 24, so it's not hugely useful right now given the low penetration of the Android N release. We do have support going forward, so marking as an enhancement.

@ghost
Copy link

ghost commented Oct 25, 2016

@ojw28 is CBC mode guaranteed in API 24 or is it an OEM 'optional' mode?

Also - what encryption pattern is suuported - cbcs or cbc1?

@ojw28
Copy link
Contributor

ojw28 commented Oct 25, 2016

Unsure. @wvpaf, do you know?

ojw28 pushed a commit that referenced this issue May 11, 2017
This will allow supporting more encryption schemes. Including some
that require more encryption data, like the encryption pattern.

Issue:#1661
Issue:#1989
Issue:#2089

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=155481889
ojw28 pushed a commit that referenced this issue Jun 22, 2017
At the moment, only CENC-defined scheme types are known values.
This will allow having more information about the encryption
scheme through the format, which in turn will allow more informed
decisions on format support.

Issue:#1661
Issue:#1989
Issue:#2089

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=159538907
ojw28 pushed a commit that referenced this issue Jun 22, 2017
Issue:#1661
Issue:#1989
Issue:#2089

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=159553419
ojw28 pushed a commit that referenced this issue Jun 22, 2017
This will extend our CENC modes support to cbcs and cens. The change was
not split into two different CLs due to lack of test content for
default initialization vectors, aside from AES-CBCS encrypted ones.

Issue:#1661
Issue:#1989
Issue:#2089

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=159810371
ojw28 pushed a commit that referenced this issue Jul 12, 2017
This CL also makes DefaultTrackSelector take it into account when RendererCapabilities
sets it to unsupported.

A following CL could add a DefaultTrackSelector parameter to force DRM "known support" for specific track types.

Issue:#1661
Issue:#1989
Issue:#2089

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=161556467
@ojw28
Copy link
Contributor

ojw28 commented Jul 16, 2017

We've added the necessary support in ExoPlayer. Note that the platform only provides the underlying support from API level 24+. We've also found quite a few API level 24+ devices that appear to not work correctly with the new crypto modes. We're following up with the device manufacturers, and also trying to get some better platform level testing in place.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants