Sniff FLAC files correctly if they have ID3 headers #4055
Comments
|
The content provided doesn't download for me. When I click the link I get a spinner indefinitely. Please can you attach a sample directly to your email, or else use a file sharing service that works reliably (e.g. DropBox / Google Drive). Note that ID3 tags at the start of FLAC files is not really a thing. As per the FLAC FAQs:
We'll take a look anyway if you're able to provide content we can access, and perhaps look into handling the case if it seems worthwhile. |
|
ok,there is link here. |
ojw28
changed the title
|
@botaydotcom - This fits nicely under the "extractor stuff" umbrella. Implementation points:
|
|
Is it possible for me to understand that there will be a new version to solve this problem? |
|
Yes, there will be a new version to solve this problem. However, this will not be worked on very soon because I'm working some other tasks on hand (expect ~1 month). |
Support parsing ID3 tags at the beginning of FLAC files, even though FLAC spec does not require this. GitHub: #4055. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=192127929
LibFlac internally can skip ID3 tags correctly. Therefore, we don't need to keep track of the whole ID3 header section and skip through this section in Java code. We can just set the whole stream to the native library, and it will handle skipping ID3 tags correctly. The only thing that the Java part need to do is peeking and parsing ID3 tags (if present), in order to populate the track format metadata. GitHub: #4055. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=193327602
On my side, I have a FLAC music format music, which has a ID3 head on the head of the format signature, which leads to FlacExtractor.sniff judgment error. He thinks he is not FLAC music.
I will send this FLAC music to you by mailbox
The text was updated successfully, but these errors were encountered: