Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Surface MediaCodecInfo isHardwareAccelerated / isSoftwareOnly / isVendor #5839

Closed
ojw28 opened this issue May 6, 2019 · 6 comments
Closed

Surface MediaCodecInfo isHardwareAccelerated / isSoftwareOnly / isVendor #5839

ojw28 opened this issue May 6, 2019 · 6 comments
Assignees
@kim-vde
Labels
enhancement

Comments

@ojw28
Copy link
Contributor

ojw28 commented May 6, 2019

Android Q has added new isHardwareAccelerated, isSoftwareOnly and isVendor methods to MediaCodecInfo. We should consider:

  1. Surfacing this information in ExoPlayer's MediaCodecInfo. It would probably make sense for us to approximate this information for earlier API levels as well (e.g. based on decoder name).
  2. Once this information is surfaced, we should potentially look at whether it should be factored into track selection decisions. For example, preferring H264 over HEVC in cases where the H264 decoder is hardware and the HEVC decoder is software.
@ojw28 ojw28 mentioned this issue May 6, 2019
Closed
@noamtamim

This comment has been minimized.

Sign in to view
@noamtamim

This comment has been minimized.

Sign in to view
@ojw28

This comment has been minimized.

Sign in to view
@andrewlewis andrewlewis assigned kim-vde and unassigned andrewlewis Aug 28, 2019
ojw28 pushed a commit that referenced this issue Aug 30, 2019
@kim-vde @ojw28
Surface MediaCodecInfo methods added in Android Q
4855555 
- Surface information provided by methods isHardwareAccelerated,
  isSoftwareOnly and isVendor added in Android Q in MediaCodecInfo
  class.
- Estimate this information based on the codec name for earlier API
  levels.

Issue:#5839
PiperOrigin-RevId: 266334850
@kim-vde
Copy link
Contributor

kim-vde commented Sep 11, 2019

Issue fixed by commit above.

@kim-vde kim-vde closed this as completed Sep 11, 2019
@noamtamim
Copy link
Contributor

@kim-vde @ojw28 do you know if these new "c2" prefixes have existed before Android Q?

@kim-vde
Copy link
Contributor

kim-vde commented Sep 13, 2019

@noamtamim Those prefixes have been introduced in Android P.

@google google locked and limited conversation to collaborators Nov 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kim-vde kim-vde

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@andrewlewis @ojw28 @noamtamim @kim-vde