Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dash Audio track selection inconsistent #6335

Closed
GouravSna opened this issue Aug 23, 2019 · 4 comments
Closed

Dash Audio track selection inconsistent #6335

GouravSna opened this issue Aug 23, 2019 · 4 comments
Assignees
Labels

Comments

@GouravSna
Copy link

GouravSna commented Aug 23, 2019

We have 2 dash DRM streams with audio tracks.
As far as we know the default language that should be picked in dash is the first audio adaptation set.
In the following streams 1,2 we can see that the dash has Hindi as the first language in manifest
But in the first we can see in Charles that the Language that is playing in the demo app is Hindi and in the second the language that is playing is Telugu by default.
Could you please explain when the first audio is selected and when other one is selected in dash please?

We have sent an email on dev.exoplayer@gmail.com by Subject Name: "Dash Audio track selection inconsistent".

We can see the same in 'release-v2' version.

-Thanks

@tonihei
Copy link
Collaborator

tonihei commented Aug 23, 2019

Thanks for filing the issue. As already indicated in the answer to your email, this may be related to your phone's system language setting. If it's set to Telugu, then this will be preferred independent of the order in the manifest. Can you verify if that's the case here?

@GouravSna
Copy link
Author

No, The device language is English.

@tonihei
Copy link
Collaborator

tonihei commented Aug 23, 2019

I'm able to reproduce the problem. But I needed to fake the user-agent because the stream doesn't load when using Android user agents.

The reason for this audio selection is that our DefaultTrackSelector prefers tracks with a higher bitrate if all other selection criteria are equal. Therefore we select Telugu with a bitrate of 64002 bps over Hindi with a bitrate of 64001 bps.

This doesn't make sense in this case and is meant for cases where different quality variants of the same audio track are provided. We should probably only apply the bitrate comparison if the language (and potentially other parameters) are the same.

@GouravSna
Copy link
Author

tonihei added a commit that referenced this issue Aug 23, 2019
The last selection criteria is the audio bitrate to prefer higher-quality
streams. We shouldn't apply this criterium though if the languages of the
tracks are different.

Issue:#6335
PiperOrigin-RevId: 265064756
@tonihei tonihei closed this as completed Aug 23, 2019
ojw28 pushed a commit that referenced this issue Sep 2, 2019
The last selection criteria is the audio bitrate to prefer higher-quality
streams. We shouldn't apply this criterium though if the languages of the
tracks are different.

Issue:#6335
PiperOrigin-RevId: 265064756
@google google locked and limited conversation to collaborators Oct 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants