Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Java based FLAC extractor #6406

Closed
ojw28 opened this issue Sep 6, 2019 · 0 comments
Closed

Implement Java based FLAC extractor #6406

ojw28 opened this issue Sep 6, 2019 · 0 comments
Assignees
@kim-vde
Labels
enhancement

Comments

@ojw28
Copy link
Contributor

ojw28 commented Sep 6, 2019 •
edited
Loading

[REQUIRED] Use case description

Allow playback of 'native' FLAC without requiring use of the FLAC extension on Android O MR1 and above. Starting from this version of Android, the platform shipped with a built in FLAC decoder that's accessible via MediaCodec.

Proposed solution

  • A Java based FLAC extractor in the core library. Unlike FlacExtractor in the FLAC extension, this implementation will only do extraction (the FLAC extension FlacExtractor also does decoding).
  • Once completed, we should consider whether or not it makes sense to deprecate and eventually remove FlacExtractor in the FLAC extension.

Alternatives considered

N/A
@google google deleted a comment from google-oss-bot Sep 6, 2019
@ojw28 ojw28 mentioned this issue Sep 10, 2019
Closed
@andrewlewis andrewlewis assigned kim-vde and unassigned andrewlewis Sep 21, 2019
ojw28 pushed a commit that referenced this issue Nov 18, 2019
@kim-vde @ojw28
Add Java FLAC extractor
9b2917a 
Seeking, live streams support and exposure of vorbis and ID3 data
are not part of this commit.

Issue: #6406
PiperOrigin-RevId: 281083332
@ojw28 ojw28 closed this as completed Jan 17, 2020
ojw28 pushed a commit that referenced this issue Jan 17, 2020
@kim-vde @ojw28
Add Java FLAC extractor
dcebf93 
Seeking, live streams support and exposure of vorbis and ID3 data
are not part of this commit.

Issue: #6406
PiperOrigin-RevId: 281083332
@Pentaphon Pentaphon mentioned this issue Feb 22, 2020
Merged
@google google locked and limited conversation to collaborators Mar 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kim-vde kim-vde

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@andrewlewis @ojw28 @kim-vde