Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support legacy E-AC-3 scheme id uri in dash manifests #6523

Closed
hbofolts1 opened this issue Oct 9, 2019 · 0 comments
Closed

Support legacy E-AC-3 scheme id uri in dash manifests #6523

hbofolts1 opened this issue Oct 9, 2019 · 0 comments
Assignees

Comments

@hbofolts1
Copy link

[REQUIRED] Use case description

I am attempting to parse dash manifests that have a schemeIdUri attribute value of urn:dolby:dash:audio_channel_configuration:2011 within the AudioChannelConfiguration element. The DashManifestParser implementation does not look for this value.

https://github.com/google/ExoPlayer/blob/release-v2/library/dash/src/main/java/com/google/android/exoplayer2/source/dash/manifest/DashManifestParser.java#L1086

       <AudioChannelConfiguration
         schemeIdUri="urn:dolby:dash:audio_channel_configuration:2011"
         value="F801">

Proposed solution

Similar to what shaka player is doing, the urn:dolby:dash:audio_channel_configuration:2011 string should also lead to calling parseDolbyChannelConfiguration.

https://github.com/google/shaka-player/blob/master/lib/dash/dash_parser.js#L1268

ojw28 pushed a commit that referenced this issue Oct 13, 2019
Issue: #6523
PiperOrigin-RevId: 274160232
ojw28 pushed a commit that referenced this issue Oct 14, 2019
Issue: #6523
PiperOrigin-RevId: 274160232
@ojw28 ojw28 closed this as completed Dec 21, 2019
@google google locked and limited conversation to collaborators Feb 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants